Skip to content

Comments

Update get_Natmort in SS_benchfore.tpl to happen with predators#371

Merged
Rick-Methot-NOAA merged 1 commit intomainfrom
fix_forecast_M_with_predators_2
Sep 23, 2022
Merged

Update get_Natmort in SS_benchfore.tpl to happen with predators#371
Rick-Methot-NOAA merged 1 commit intomainfrom
fix_forecast_M_with_predators_2

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA commented Sep 22, 2022

Concisely (20 words or less) describe the issue

get_NatMort() needs to be called if predators are used

Please Link issue(s)

none
resolves #[add issue number number], resolves #[optional second issue number if more than 1 issue addressed.]

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

none

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

no need, tests had already occurred in old stale branch

Has any new code been documented?

none
If not, please add documentation before submitting the Pull Request.

  • I have documented any new code added (or no new code was added)

is there an input change for users to Stock Synthesis?

  • Yes, there was an input change

If so, please provide an example of the new inputs needed.

[New example stock synthesis input goes here]

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

none

If changes are needed in the change log, please fill in the table here:

Action Topics Type
[fix, new, or revise] [e.g., biology. Use issue label options.] [input, output, and/or calc, or ALL]

Additional information (optional):

none

@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.20 milestone Sep 22, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA self-assigned this Sep 22, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 9f66110 into main Sep 23, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the fix_forecast_M_with_predators_2 branch September 23, 2022 16:41
@Rick-Methot-NOAA
Copy link
Collaborator Author

bypassing review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant