Conversation
Contributor
Author
|
I checked and the fallthrough statement is indeed gone! The call-build-ss3-warnings is still failing as it is on main because of other warnings (that would need to be fixed on the admb side of things, and may have been fixed already!) |
nschindler-noaa
approved these changes
Aug 24, 2022
Contributor
nschindler-noaa
left a comment
There was a problem hiding this comment.
The fallthrough statement is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely (20 words or less) describe the issues
Removes a warning
Please Link issue(s)
resolves #[add issue number number], resolves #[optional second issue number if more than 1 issue addressed.]
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
The call-build-ss3-warnings artifact file should be checked for presence of the implicit fallthrough warning (which should no longer be present):
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
@nschindler-noaa , could you check if the fallthrough is intentional, or if this should be
break;instead?Has any new code been documented?
If not, please add documentation before submitting the Pull Request.
-[x] I have documented any new code added (or no new code was added)
is there an input change for users to Stock Synthesis?
If so, please provide an example of the new inputs needed.
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):
If changes are needed in the change log, please fill in the table here:
Additional information (optional):