Merged
Conversation
Fine tuning error message.
Contributor
Author
|
Rick, this is ready for merge. |
Contributor
Author
|
Next up: SS_readcontrol_330.tpl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely (20 words or less) describe the issue
converted SS_readdata_330.tpl to use write_warning for warn messages.
Please Link issue(s)
issue #320
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
compiles, ran Big_Skate_2019 with no problems
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
Has any new code been documented?
write_warning is in SS_global.tpl
code in SS_readdata_330 has been changed and reduced a little.
If not, please add documentation before submitting the Pull Request.
is there an input change for users to Stock Synthesis?
No input changes
If so, please provide an example of the new inputs needed.
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):
If changes are needed in the change log, please fill in the table here:
Additional information (optional):