Skip to content

Comments

320 standardize exit message#356

Merged
nschindler-noaa merged 7 commits intomainfrom
320-standardize-exit-message
Jul 20, 2022
Merged

320 standardize exit message#356
nschindler-noaa merged 7 commits intomainfrom
320-standardize-exit-message

Conversation

@nschindler-noaa
Copy link
Contributor

Concisely (20 words or less) describe the issue

converted SS_readdata_330.tpl to use write_warning for warn messages.

Please Link issue(s)

issue #320

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

compiles, ran Big_Skate_2019 with no problems

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Has any new code been documented?

write_warning is in SS_global.tpl
code in SS_readdata_330 has been changed and reduced a little.

If not, please add documentation before submitting the Pull Request.

  • I have documented any new code added (or no new code was added)

is there an input change for users to Stock Synthesis?

No input changes

  • Yes, there was an input change

If so, please provide an example of the new inputs needed.

[New example stock synthesis input goes here]

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

If changes are needed in the change log, please fill in the table here:

Action Topics Type
[fix, new, or revise] [e.g., biology. Use issue label options.] [input, output, and/or calc, or ALL]

Additional information (optional):

@Rick-Methot-NOAA Rick-Methot-NOAA self-requested a review July 20, 2022 19:28
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Neal

@nschindler-noaa
Copy link
Contributor Author

Rick, this is ready for merge.

@nschindler-noaa nschindler-noaa merged commit 6b092fd into main Jul 20, 2022
@nschindler-noaa
Copy link
Contributor Author

Next up: SS_readcontrol_330.tpl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants