Skip to content

Comments

Correct text in starter.ss regarding depletion settings#340

Merged
Rick-Methot-NOAA merged 1 commit intomainfrom
k-doering-NOAA-patch-1
Jul 7, 2022
Merged

Correct text in starter.ss regarding depletion settings#340
Rick-Methot-NOAA merged 1 commit intomainfrom
k-doering-NOAA-patch-1

Conversation

@k-doering-NOAA
Copy link
Contributor

What issue(s) does this PR address?

(note: including the keyword "resolves" means the issue will be closed automatically when merged in.)
This changes the depletion setting line in starter.ss_new to read SPBvirgin instead of SPB0 for option 1, which clarifies that the virgin biomass is used and not unfished biomass.

Link issue(s), replacing everything in [ ]: n/a

Describe the issue, if not included in the PR

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

n/a

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

n/a

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

Change the wording in the manual

If changes are needed in the change log, please fill in the table here:

Version Date Description Issue Input change Action Topic Type
3.30.20 [Add date] [add concise description] #[add issue] [yes or no] [fix, new, or revise] [e.g., biology. Use issue label options.] [input, output, and/or calc, or ALL]

Additional information (optional):

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit c55b639 into main Jul 7, 2022
@k-doering-NOAA k-doering-NOAA deleted the k-doering-NOAA-patch-1 branch August 10, 2022 20:25
@Rick-Methot-NOAA Rick-Methot-NOAA changed the title Use virgin instead of 0 in depletion settings Correct text in starter.ss regarding depletion settings Sep 16, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.20 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants