Skip to content

Comments

320 standardize exit message#331

Merged
nschindler-noaa merged 2 commits intomainfrom
320-standardize-exit-message
Jun 10, 2022
Merged

320 standardize exit message#331
nschindler-noaa merged 2 commits intomainfrom
320-standardize-exit-message

Conversation

@nschindler-noaa
Copy link
Contributor

What issue(s) does this PR address? Describe and add issue numbers, if applicable.

Link issue(s) here:

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):

Additional information (optional):

Added "unknown condition" to error message in case no message sent.
SS_readstarter.tpl changed to use write_warning
SS_global.tpl write_warning and write_message tweaked.
@nschindler-noaa
Copy link
Contributor Author

This updates SS_readstarter.tpl to coding standards and implements write_warning for warning messages in SS_readstarter and SS_global.
example:
warnstream << "starter.ss has extra input lines; check echoinput to verify read"; // message to output
write_warning(N_warn,0,1); // N_warn (required), 0-whether to output to echoinput, 1-fatal flag (will output to cout and exit)

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Neal. Looking forward to using the new function throughout the code

@nschindler-noaa nschindler-noaa merged commit e0a155e into main Jun 10, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.20 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants