Skip to content

Comments

Added write_message and write_warning#327

Merged
Rick-Methot-NOAA merged 4 commits intomainfrom
320-standardize-exit-message
May 27, 2022
Merged

Added write_message and write_warning#327
Rick-Methot-NOAA merged 4 commits intomainfrom
320-standardize-exit-message

Conversation

@nschindler-noaa
Copy link
Contributor

What issue(s) does this PR address? Describe and add issue numbers, if applicable.

Link issue(s) here:

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):

Additional information (optional):

@nschindler-noaa nschindler-noaa linked an issue May 27, 2022 that may be closed by this pull request
Also, some readstarter updated.
@Rick-Methot-NOAA
Copy link
Collaborator

Neal,
This looks good. Let's pause after this conversion of warnings in readdata so we can get some other pull requests completed.

@nschindler-noaa
Copy link
Contributor Author

nschindler-noaa commented May 27, 2022 via email

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit de457e0 into main May 27, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.20 milestone Sep 16, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added misc. output change log use for issues that should appear in change log labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change log use for issues that should appear in change log misc. output

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Standardize exit message

2 participants