#321: use exit(1) instead of abort()#323
Merged
Rick-Methot-NOAA merged 1 commit intomainfrom May 24, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue(s) does this PR address? Describe and add issue numbers, if applicable.
Link issue(s) here: #321
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
None, because this change is very simple. Given we use exit(1) elsewhere in the code, it doesn't seem necessary to test this small change.
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
@Rick-Methot-NOAA to review the change and "approve" it or request edits.
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):
Not sure if this change is worth documenting in the change log? It's really small.
Additional information (optional):