Skip to content

Comments

Create write comp func#309

Merged
Rick-Methot-NOAA merged 3 commits intomainfrom
create_write_comp_func
May 9, 2022
Merged

Create write comp func#309
Rick-Methot-NOAA merged 3 commits intomainfrom
create_write_comp_func

Conversation

@nschindler-noaa
Copy link
Contributor

@nschindler-noaa nschindler-noaa commented May 9, 2022

What issue(s) does this PR address? Describe and add issue numbers, if applicable.

Link issue(s) here:

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):

Additional information (optional):

@Rick-Methot-NOAA Rick-Methot-NOAA self-requested a review May 9, 2022 18:31
Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses a requested streamlining of the code that produces compreport.sso.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 02dddc1 into main May 9, 2022
@k-doering-NOAA k-doering-NOAA added this to the 3.30.20 milestone May 10, 2022
@k-doering-NOAA k-doering-NOAA deleted the create_write_comp_func branch May 10, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants