check lambda impact on likelihood for catch vs. equilibrium catch

[k-doering-NOAA]

Imported from redmine, Issue #83773
Opened by @iantaylor-NOAA on 2020-10-09
Status when imported: Resolved

@richard.methot found that the "Malawi_Demo" model used in the October 2020 course had lambda = 0 for the catch likelihood (like_comp = 8) which seemed to be interacting with the initial equilibrium catch likelihood, when that should have required a separate entry for like_comp = 9.

[k-doering-NOAA]

comment from @RickMethot on 2020-10-09:
got it:
this like was using catch_lambda, not init_equ_lambda
obj_fun += equ_catch_like*column(init_equ_lambda,k_phase);

[Rick-Methot-NOAA]

a quick targeted test should resolve this issue easily

[k-doering-NOAA]

I just realized this was never tested; do we still need, @Rick-Methot-NOAA ?

[Rick-Methot-NOAA]

it was pretty simple and I did a near unit test when I fixed it. So I am confident it is OK. Rarely used