switch to compiling with ADMB 12.3 upon its release

[k-doering-NOAA]

ADMB 12.3 will likely be released soon (probably in the next few weeks). Should we test it out once available and try to switch over to compiling SS with this version? I think there would be several advantages, including a fix that should speed up runs (relative to ADMB 12.2), the -hess_step option, and a fix for reading input files with OSX9 line endings.

[Rick-Methot-NOAA]

definitely yes. Please take the lead on the testing.

[k-doering-NOAA]

ADMB 12.3 runs SS models slightly faster compared to 12.2 (similar to 12.1), which is good (details in email with subject ADMB 12.2 speed issue). The next step would be to try running the tests on jenkins with ADMB 12.3 and seeing if any results change or if we see any segmentation errors.

[k-doering-NOAA]

Also ran ADMB 12.3 with the model test set and found a similar reduction in run time: 10h 39 min to run the models, versus 11 hr 1 min with ADMB 12.2.

Also, there were no changes in the model results, so it seems we can safely switch over to 12.3 when it is ready.

[Rick-Methot-NOAA]

concur. I will download it to my local machine also.

[k-doering-NOAA]

I should note, ADMB 12.3 has not been released yet! I was testing a branch in the ADMB repository. I think we should wait for the official release (which I think should be soon, maybe next week?) to switch over

[k-doering-NOAA]

The steps necessary to complete once the release occurs:

• Switch jenkins jobs to use ADMB 12.3
• Switch github actions jobs to use ADMB 12.3
• Add ADMB 12.3 to mac mini
• Add ADMB 12.3 to tumnus
• RM switch over to ADMB 12.3 locally
• Other SS dev team members use ADMB 12.3 to compile locally (this is less critical, since the rest of us don't typically compile locally)

[k-doering-NOAA]

ADMB 12.3 has been released: https://github.com/admb-project/admb/releases/tag/ADMB-12.3 so we can start transitioning.

[k-doering-NOAA]

@iantaylor-NOAA , would you mind asking IT to get admb 12.3 onto tumnus and mac mini? not too much a rush, given we have gh actions, but we may still need it sometimes.

I've update all the builds on gh actions (currently in a branch) and am now testing that admb 12.3 works as expect on jenkins. We should know tomorrow if it does, and can merge in the branch to main at that time if it works ok.