Skip to content

Bump ndarray to 0.16#9

Merged
nmandery merged 3 commits intonmandery:mainfrom
kylebarron:kyle/bump-ndarray
Oct 22, 2024
Merged

Bump ndarray to 0.16#9
nmandery merged 3 commits intonmandery:mainfrom
kylebarron:kyle/bump-ndarray

Conversation

@kylebarron
Copy link
Contributor

No description provided.

@kylebarron
Copy link
Contributor Author

I'm not sure what's different so as to no longer be able to build GDAL on CI

@nmandery
Copy link
Owner

The gdal crate itself depends on ndarray 0.15. PR is in georust/gdal#569.

This crate requires gdal only for one example, we could also just comment out this example and the gdal dev-dependency.

@kylebarron
Copy link
Contributor Author

Ah I see. It seemed that numpy 0.22 forced a ndarray 0.15 upgrade. If you think gdal will upgrade to 0.16 soon anyways, then maybe we just comment out the example for now?

@nmandery
Copy link
Owner

Just comment it out - it is just a non-essential example.

@kylebarron
Copy link
Contributor Author

kylebarron commented Oct 22, 2024

It looks like crates.io allows git tags for dev dependencies (it just ignores them), so I'm going to try pinning the latest main of gdal here. Can you run the CI? @nmandery

@nmandery nmandery merged commit 775c0df into nmandery:main Oct 22, 2024
@nmandery
Copy link
Owner

Thank you for this PR. I already pushed the this as version 0.9.0 to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants