relax float equality comparison #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The included test seems to lead to an infinte loop, due to a bug in the `rand` package, version `0.8.5`. The bug is fixed in `rand` version `0.9`, but that version is not released yet. Either way, it can be worked around, if care is taken when to sample a uniform distribution. This commit samples a uniform distribution only if the absolute difference between the two numbers is greater than 1e-4 parts of the smaller one (1%%). Otherwise, it assumes that the numbers are the same and just uses the smaller one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included test seems to lead to an infinte loop, due to a bug in the
randpackage, version0.8.5. The bug is fixed inrandversion0.9, but that version is not released yet.Either way, it can be worked around, if care is taken when to sample a uniform distribution. This commit samples a uniform distribution only if the absolute difference between the two numbers is greater than 1e-6 parts of the smaller one (1%%%). Otherwise, it assumes that the numbers are the same and just uses the smaller one.