Add context to ExpressionVisitor #164
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nls-jajuko
reviewed
Oct 29, 2025
Collaborator
There was a problem hiding this comment.
should we add more fields to this or add some sort of custom FilterContext builder
nls-jajuko
reviewed
Oct 29, 2025
Collaborator
There was a problem hiding this comment.
Should we add more fields to FilterContext or add some sort of custom FilterContext builder
I have a use case for feature type's storageSrid and projection transform factory.
Collaborator
Author
|
Made FilterContext an interface, made ExpressionVisitor generic and set ExpressionToHakunaFilter generic type . Added more functions to FilterContext to access the storageSrid and projection transformer to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New way to access "context" throughout ExpressionVisitor.
Provide more knowledge of filterSrid to ExpressionVisitor (ExpressionToHakunaFilter) via FilterContext.
Additionally, nested FunctionCalls are now supported (see ExpressionToHakunaFilterTest)
This is preliminary work for something @nls-jajuko needs and as such I'll open this as a Draft PR for now.