Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue when using with newer Transformers library #5

Closed
CaoHoangTung opened this issue Jan 29, 2021 · 6 comments
Closed

Comments

@CaoHoangTung
Copy link

I'm running into an issue when trying to use trankit in a project which use a new version of huggingface transformers library. Trankit depends on adapter-transformers, which cannot be simutanously used with transformers

@minhhdvn
Copy link
Collaborator

minhhdvn commented Jan 29, 2021

Hi @CaoHoangTung,
Thanks for pointing it out.
adapter-transformers is built on top of transformers and the current implementation of the adapter-transformers indeed causes the compatibility issue with transformers sometimes. For now, as trankit depends on adapter-transformers so we are not able to solve this issue ourselves. We have a plan to separate trankit from adapter-transformers and hopefully this would solve the problem in the future.
Thanks.

@loukey
Copy link

loukey commented Apr 3, 2021

Hi @minhhdvn, is that problem fixed? I still can't use transkit with transformers because of the version of adapter-transformers.

@minhhdvn minhhdvn pinned this issue Apr 3, 2021
@minhhdvn
Copy link
Collaborator

minhhdvn commented Apr 3, 2021

Hi @loukey and @CaoHoangTung,
We have figured out the way to fix this compatibility issue in version 1.0.1 of trankit. Please install the new version with the command:
pip install trankit==1.0.1.
Thank you.

@loukey
Copy link

loukey commented Apr 3, 2021

Hi @loukey and @CaoHoangTung,
We have figured out the way to fix this compatibility issue in version 1.0.1 of trankit. Please install the new version with the command:
pip install trankit==1.0.1.
Thank you.

Thank you! :)

@ScDor
Copy link

ScDor commented Apr 3, 2021 via email

@minhhdvn
Copy link
Collaborator

minhhdvn commented Apr 3, 2021

Thanks for your suggestion, @ScDor.
We have added the instructions to the README and the documentation page.

Thanks! Any chance to add this to the installation/usage instructions?

On Sat, Apr 3, 2021, 21:35 Songjian Chen @.***> wrote: Hi @loukey https://github.com/loukey and @CaoHoangTung https://github.com/CaoHoangTung, We have figured out the way to fix this compatibility issue in version 1.0.1 of trankit. Please install the new version with the command: pip install trankit==1.0.1. Thank you. Thank you! :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEKVIEVEMFO4T7K25UJEAQLTG5NX7ANCNFSM4WY6LOWQ .

@minhhdvn minhhdvn closed this as completed Apr 6, 2021
@laiviet laiviet unpinned this issue Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants