-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cmake install #911
Fix/cmake install #911
Conversation
@@ -16,12 +16,12 @@ include(ExternalProject) | |||
## OPTIONS | |||
## | |||
option(JSON_BuildTests "Build the unit tests when BUILD_TESTING is enabled." ON) | |||
option(JSON_MultipleHeaders "Use non-amalgamated version of the library." OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would anyone want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To include the json_fwd.hpp
file, or the adl_serializer.hpp
. That's something I want to use at work, I like to only include what I need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Thanks! |
Would be nice if you would include a bit of documentation on how to install this. |
It's like any other CMake project: mkdir build
cd build
mkdir local
cmake .. -DCMAKE_INSTALL_PREFIX=$(pwd)/local
make
make install After that, you should have
|
Thanks for the info. |
This PR fixes the CMake installation directory issue described in #910. (Due to PR #700)
It also adds a new CMake option to let users install the non-amalgamated version of the library.
The
amalgamate
tool was moved to avoid it to be installed as wellPull request checklist