add ensure_ascii parameter to dump. #330 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmarr
reviewed
Jul 11, 2017
src/json.hpp
Outdated
|
|
||
| @param[in] indent If indent is nonnegative, then array elements and object | ||
| members will be pretty-printed with that indent level. An indent level of | ||
| `0` will only insert newlines. `-1` (the default) selects the most compact | ||
| representation. | ||
| @param[in] indent_char The character to use for indentation if @a indent is | ||
| greater than `0`. The default is ` ` (space). | ||
| @param[in] ensure_ascii If ensure_ascii is true (the default), all non-ASCII |
There was a problem hiding this comment.
The default in the function declaration is false.
nlohmann
requested changes
Jul 11, 2017
src/json.hpp
Outdated
|
|
||
| @return string containing the serialization of the JSON value | ||
|
|
||
| @complexity Linear. | ||
|
|
||
| @liveexample{The following example shows the effect of different @a indent | ||
| parameters to the result of the serialization.,dump} |
There was a problem hiding this comment.
The , here is required. It separates the description (The following example...) from the name of the example dump (see file doc/examples/dump.cpp).
Please undo this change.
|
Thanks for the PR! Let's wait for Travis/Coveralls to finish. |
|
Thanks a lot! |
|
Happy to help! The library is wonderful and it made my project a joy to
program. Thank you!
…On Wed, Jul 12, 2017, 01:59 Niels Lohmann ***@***.***> wrote:
Thanks a lot!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#654 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_FFxn5MPYkU3bozw77T19s0y-nr3DAks5sNGCqgaJpZM4OUl1g>
.
|
|
@ryanjmulder Unfortunately, I found an error in the code, see #656. Maybe you have an idea how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.