Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation issue #4613

Merged
merged 3 commits into from
Jan 22, 2025
Merged

fix compilation issue #4613

merged 3 commits into from
Jan 22, 2025

Conversation

hnampally
Copy link
Contributor

#4019

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

@hnampally
fix compilation issue
d055473 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@hnampally hnampally requested a review from nlohmann as a code owner January 20, 2025 06:33
@coveralls
Copy link

coveralls commented Jan 20, 2025 •
edited
Loading

Coverage Status

coverage: 99.186%. remained the same
when pulling 3677d24 on hnampally:issue-4019
into bd4fea3 on nlohmann:develop.

@hnampally
add unit test
b68bd16 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@hnampally
fix ci failure check
3677d24 
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@github-actions GitHub Actions
Copy link

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @hnampally
Please read and follow the Contribution Guidelines.

nlohmann
nlohmann approved these changes Jan 22, 2025
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann linked an issue Jan 22, 2025 that may be closed by this pull request
flatten() function does not compile if an alternative string type is used #4019
Closed
2 tasks
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 22, 2025
@nlohmann nlohmann merged commit bf8ccc2 into nlohmann:develop Jan 22, 2025
131 checks passed
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr left review comments

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
M tests
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.

flatten() function does not compile if an alternative string type is used
4 participants
@hnampally @coveralls @nlohmann @gregmarr