Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json_pointer/string_t equality comparison operators #3664

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Add json_pointer/string_t equality comparison operators #3664

merged 4 commits into from
Aug 5, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Aug 3, 2022 •
edited
Loading

  • Add operator overloads for equality comparison with strings.

  • Add C++20-compliant comparisons.

  • Add unit tests.

Fixes #3654.

To Do:

  • Update documentation:
    • Add missing operator pages.

@coveralls
Copy link

coveralls commented Aug 3, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3dbd31f on falbrechtskirchinger:json_pointer-operators_issue3654 into e839f58 on nlohmann:develop.

@falbrechtskirchinger
Copy link
Contributor Author

falbrechtskirchinger commented Aug 3, 2022 •
edited
Loading

This PR is ready for code review. Documentation is missing two pages: api/json_pointer/operator_eq.md and api/json_pointer/operator_ne.md

The other regression PR has some minor issues I'm still figuring out and may expand in scope.

@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Aug 3, 2022
Closed
@falbrechtskirchinger falbrechtskirchinger force-pushed the json_pointer-operators_issue3654 branch 2 times, most recently from 58896f1 to 5bdbae4 Compare August 5, 2022 08:14
@falbrechtskirchinger falbrechtskirchinger force-pushed the json_pointer-operators_issue3654 branch from 5bdbae4 to 3dbd31f Compare August 5, 2022 08:23
falbrechtskirchinger
falbrechtskirchinger commented Aug 5, 2022
View reviewed changes
Copy link
Contributor Author

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review August 5, 2022 08:25
nlohmann
nlohmann approved these changes Aug 5, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 5, 2022
@nlohmann nlohmann merged commit 9e1a7c8 into nlohmann:develop Aug 5, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the json_pointer-operators_issue3654 branch August 5, 2022 12:08
@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
documentation L tests
Projects
None yet
Milestone
Release 3.11.2
Development

Successfully merging this pull request may close these issues.

Regression: no match for 'operator!=' comparing json_pointer and const char */string_t
3 participants
@falbrechtskirchinger @coveralls @nlohmann