Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator<<(json_pointer) #3601

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Add operator<<(json_pointer) #3601

merged 10 commits into from
Jul 28, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Fixes #3600.

@coveralls
Copy link

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f2d8001 on falbrechtskirchinger:json_pointer-ostream-issue3600 into 2d48a4d on nlohmann:develop.

nlohmann
nlohmann reviewed Jul 23, 2022
View reviewed changes
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 23, 2022
@falbrechtskirchinger falbrechtskirchinger force-pushed the json_pointer-ostream-issue3600 branch 2 times, most recently from 7f89e94 to 45af879 Compare July 24, 2022 06:50
@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review July 24, 2022 06:52
@falbrechtskirchinger
Copy link
Contributor Author

@nlohmann I don't quite understand how json::json_pointer ptr; std::cout << ptr; prints "" according to the *.output files. operator<<(std::ostream&, const std::basic_string<...> &) doesn't add quotes to my knowledge and experience.

"" is certainly desirable over blank lines but then we should add the quotes explicitly to the examples.

@falbrechtskirchinger falbrechtskirchinger force-pushed the json_pointer-ostream-issue3600 branch from 4d3e37c to 37ab8d9 Compare July 24, 2022 11:02
@falbrechtskirchinger falbrechtskirchinger force-pushed the json_pointer-ostream-issue3600 branch from 37ab8d9 to e6d7cfe Compare July 25, 2022 20:17
@falbrechtskirchinger
Copy link
Contributor Author

I'll update docset in #3553 to avoid merge conflicts.

@nlohmann
Copy link
Owner

@nlohmann I don't quite understand how json::json_pointer ptr; std::cout << ptr; prints "" according to the *.output files. operator<<(std::ostream&, const std::basic_string<...> &) doesn't add quotes to my knowledge and experience.

"" is certainly desirable over blank lines but then we should add the quotes explicitly to the examples.

I'll check.

nlohmann
nlohmann approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 28, 2022
@nlohmann nlohmann merged commit e3095f6 into nlohmann:develop Jul 28, 2022
@falbrechtskirchinger
Copy link
Contributor Author

@nlohmann I don't quite understand how json::json_pointer ptr; std::cout << ptr; prints "" according to the *.output files. operator<<(std::ostream&, const std::basic_string<...> &) doesn't add quotes to my knowledge and experience.
"" is certainly desirable over blank lines but then we should add the quotes explicitly to the examples.

I'll check.

What did you find out?

@falbrechtskirchinger falbrechtskirchinger deleted the json_pointer-ostream-issue3600 branch July 28, 2022 20:14
@nlohmann
Copy link
Owner

@nlohmann I don't quite understand how json::json_pointer ptr; std::cout << ptr; prints "" according to the *.output files. operator<<(std::ostream&, const std::basic_string<...> &) doesn't add quotes to my knowledge and experience.
"" is certainly desirable over blank lines but then we should add the quotes explicitly to the examples.

I'll check.

What did you find out?

The quotes disappeared when I used your branch. I will adjust the examples to avoid confusion around empty lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

json_pointer__pop_back.cpp example does not compile
4 participants
@falbrechtskirchinger @coveralls @nlohmann @gregmarr