Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update CI #3368

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix and update CI #3368

merged 2 commits into from
Mar 6, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Mar 2, 2022 •
edited
Loading

Per GitHub's announcement [1] the windows-latest runner has migrated to Windows Server 2022 and ships with different tool versions. Specifically, it no longer includes MSVC 2019. Use windows-2019 instead.

The manual trigger workflow_dispatch has been added to all workflows allowing them to be manually triggered from the Actions tab (via the "Run Workflow" drop-down). This can be used to trigger a CI run on branches other than develop, master, or release/*, and by forks prior to creating a PR.

Add topic/* to the list of push triggers. Again, this is useful to run CI more easily during development. I've chosen a neutral name without a common prefix with other branches to not interfere with tab completion (e.g., devel/ and develop).

[1] https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/
[2] https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#language-and-runtime

@coveralls
Copy link

coveralls commented Mar 2, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 64a2e05 on falbrechtskirchinger:update-ci into e4643d1 on nlohmann:develop.

@falbrechtskirchinger
CI: change msvc2019*/clang* runners to windows-2019
64a2e05 
GitHub updated their runners. windows-latest is now based on Windows
Server 2022 and comes with different tool versions.
MSVC 2019 is still available via the windows-2019 runner.
@falbrechtskirchinger falbrechtskirchinger changed the title CI: change msvc2019* runners / add workflow_dispatch trigger CI: change msvc2019*/clang* runners / add workflow_dispatch trigger Mar 2, 2022
@falbrechtskirchinger
Copy link
Contributor Author

I've addressed clang* builds as well and edited my PR message accordingly.

@falbrechtskirchinger falbrechtskirchinger changed the title CI: change msvc2019*/clang* runners / add workflow_dispatch trigger Fix and update CI Mar 5, 2022
@nlohmann
Copy link
Owner

nlohmann commented Mar 6, 2022

@falbrechtskirchinger Thanks for the PR - one question: does the used compiler versions change; that is, does the table in https://github.com/nlohmann/json#supported-compilers need to be updated?

@nlohmann
Copy link
Owner

nlohmann commented Mar 6, 2022 •
edited
Loading

@falbrechtskirchinger Thanks for the PR - one question: does the used compiler versions change; that is, does the table in https://github.com/nlohmann/json#supported-compilers need to be updated?

No worries - I did not realize the CI does not work without this fix. I will merge and check the versions later.

Edit: I still have a question, see below.

@nlohmann nlohmann self-assigned this Mar 6, 2022
@falbrechtskirchinger
Copy link
Contributor Author

@falbrechtskirchinger Thanks for the PR - one question: does the used compiler versions change; that is, does the table in https://github.com/nlohmann/json#supported-compilers need to be updated?

The precise version might have. Need to double check.

@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Mar 6, 2022
Merged
nlohmann
nlohmann approved these changes Mar 6, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.10.6 milestone Mar 6, 2022
@nlohmann
Copy link
Owner

nlohmann commented Mar 6, 2022

Thanks! I will merge once the CI is green.

@falbrechtskirchinger
Copy link
Contributor Author

FYI:
Visual Studio Enterprise 2019
Version 16.11.32126.315

From a previous CI run:

Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework

https://github.com/nlohmann/json#supported-compilers lists:

Microsoft Visual C++ 2019 / Build Tools 16.3.1+1def00d3d (and possibly later)

@nlohmann nlohmann merged commit d1e57df into nlohmann:develop Mar 6, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the update-ci branch March 6, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann