Skip to content

Commit

Permalink
chore: lint fixes for stylelint
Browse files Browse the repository at this point in the history
  • Loading branch information
Robbert committed Oct 31, 2021
1 parent d2cd062 commit f349a06
Show file tree
Hide file tree
Showing 26 changed files with 79 additions and 62 deletions.
1 change: 1 addition & 0 deletions components/badge-data/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

.utrecht-badge-data {
@extend .utrecht-badge;

letter-spacing: var(--utrecht-badge-data-letter-spacing, inherit);
text-transform: var(--utrecht-badge-data-text-transform, inherit);
}
1 change: 1 addition & 0 deletions components/badge-status/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

.utrecht-badge-status {
@extend .utrecht-badge;

letter-spacing: var(--utrecht-badge-status-letter-spacing, inherit);
text-transform: var(--utrecht-badge-status-text-transform, inherit);
}
Expand Down
3 changes: 2 additions & 1 deletion components/breadcrumb/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
--utrecht-link-hover-text-decoration: var(--utrecht-link-text-decoration);
--utrecht-link-visited-color: var(--utrecht-breadcrumb-link-color);
--utrecht-link-visited-text-decoration: var(--utrecht-link-text-decoration);
font-family: var(--utrecht-document-font-family, inherit);

font-family: var(--utrecht-document-font-family, inherit);
font-size: var(--utrecht-breadcrumb-font-size);
text-transform: var(--utrecht-document-text-transform, inherit);
}
Expand Down Expand Up @@ -55,6 +55,7 @@ ol.utrecht-breadcrumb__list {
.utrecht-breadcrumb--arrows {
/* https://css-tricks.com/triangle-breadcrumbs/ */
--utrecht-breadcrumb-arrow-size: 24px;

overflow: hidden;

.utrecht-breadcrumb__link {
Expand Down
4 changes: 2 additions & 2 deletions components/button/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-button:focus:not(:disabled):not([aria-disabled="true"]):not(.utrecht-button--disabled) {
@extend .utrecht-button--focus;
@extend .utrecht-button--focus-visible;
Expand All @@ -77,7 +77,7 @@
/* override the `:focus` selector above */
/* stylelint-disable-next-line no-descending-specificity */
.utrecht-button:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-button:focus-visible {
Expand Down
2 changes: 1 addition & 1 deletion components/checkbox/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@
@extend .utrecht-checkbox--disabled;
}

@include utrecht-focus-pseudo-classes-backwards-compatible();
@include utrecht-focus-pseudo-classes-backwards-compatible;
}
6 changes: 3 additions & 3 deletions components/common/focus/_bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ $utrecht-focus-visible-fallback: true !default;
}

@mixin utrecht-focus-visible {
@include utrecht-focus-ring();
@include utrecht-focus-ring;
}

@mixin utrecht-focus-pseudo-classes {
Expand All @@ -41,9 +41,9 @@ $utrecht-focus-visible-fallback: true !default;
// use this mixin instead of the `utrecht-focus-pseudo-classes` mixin.
@mixin utrecht-focus-pseudo-classes-backwards-compatible {
&:focus {
@include utrecht-focus-ring();
@include utrecht-focus-ring;
}
&:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
}
10 changes: 6 additions & 4 deletions components/custom-checkbox/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

.utrecht-custom-checkbox {
--utrecht-icon-size: var(--utrecht-custom-checkbox-icon-size, calc(0.75 * var(--utrecht-custom-checkbox-size)));

display: inline-block;
height: var(--utrecht-custom-checkbox-size);
position: relative;
Expand All @@ -23,6 +24,7 @@

.utrecht-custom-checkbox__input {
@include reset-input-checkbox;

height: var(--utrecht-custom-checkbox-size);
opacity: 0%;
width: var(--utrecht-custom-checkbox-size);
Expand Down Expand Up @@ -92,7 +94,7 @@
}

.utrecht-custom-checkbox__box--focus {
@include utrecht-focus();
@include utrecht-focus;

background-color: var(
--utrecht-custom-checkbox-focus-background-color,
Expand All @@ -104,7 +106,7 @@
}

.utrecht-custom-checkbox__box--focus-visible {
@include utrecht-focus-visible();
@include utrecht-focus-visible;
}

.utrecht-custom-checkbox__input:indeterminate ~ .utrecht-custom-checkbox__box {
Expand All @@ -113,11 +115,11 @@

.utrecht-custom-checkbox__input:focus ~ .utrecht-custom-checkbox__box {
@extend .utrecht-custom-checkbox__box--focus;
@include utrecht-focus-ring();
@include utrecht-focus-ring;
}

.utrecht-custom-checkbox__input:focus:not(:focus-visible) ~ .utrecht-custom-checkbox__box {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}

.utrecht-custom-checkbox__icon--checked,
Expand Down
1 change: 1 addition & 0 deletions components/digid-button/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
--utrecht-button-min-block-size: var(--utrecht-digid-button-block-size, 50px);
--utrecht-logo-max-height: var(--utrecht-digid-button-block-size, 50px);
--utrecht-logo-max-width: var(--utrecht-digid-button-block-size, 50px);

block-size: var(--utrecht-digid-button-block-size, 50px);
display: inline-flex;
gap: var(--utrecht-space-inline-sm);
Expand Down
1 change: 1 addition & 0 deletions components/icon/stencil.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

:host {
display: inline-block;

/* prevent custom element dimensions to be larger than icon size because of line-height */
height: var(--utrecht-icon-size);
width: var(--utrecht-icon-size);
Expand Down
4 changes: 2 additions & 2 deletions components/link-list/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
/* reset before other stylesheets */
.utrecht-link-list,
.utrecht-link-list--html-ul {
@include reset-ul();
@include reset-ul;

& > li {
@include reset-li();
@include reset-li;
}
}

Expand Down
1 change: 1 addition & 0 deletions components/link-social/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

.utrecht-link-social {
--utrecht-icon-color: var(--utrecht-color-white);

background-color: var(--utrecht-color-red-40);
border: 2px solid var(--utrecht-color-white);
border-radius: 50%;
Expand Down
9 changes: 5 additions & 4 deletions components/link/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,27 @@
}

.utrecht-link--focus {
@include utrecht-focus();
@include utrecht-focus;

color: var(--utrecht-link-focus-color, var(--utrecht-link-color));
text-decoration: var(--utrecht-link-focus-text-decoration, var(--utrecht-link-text-decoration, underline));
}

.utrecht-link--focus-visible {
@include utrecht-focus-visible();
@include utrecht-focus-visible;
}

// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-link:focus {
@extend .utrecht-link--focus;
@extend .utrecht-link--focus-visible;
}

.utrecht-link:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-link:focus {
Expand Down
4 changes: 2 additions & 2 deletions components/link/html.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-html a:focus {
@extend .utrecht-link--focus;
@extend .utrecht-link--focus-visible;
}

.utrecht-html a:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-html a:focus {
Expand Down
7 changes: 5 additions & 2 deletions components/mapcontrolbutton/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
.utrecht-mapcontrolbutton {
--utrecht-icon-size: var(--utrecht-mapcontrolbutton-min-block-size);
--utrecht-icon-color: var(--utrecht-mapcontrolbutton-color);

align-items: center;
background-color: var(--utrecht-mapcontrolbutton-background-color);
border-color: var(--utrecht-mapcontrolbutton-border-color);
Expand All @@ -29,6 +30,7 @@
.utrecht-mapcontrolbutton:disabled,
.utrecht-mapcontrolbutton--disabled {
--utrecht-icon-color: var(--utrecht-mapcontrolbutton-disabled-color, var(--utrecht-mapcontrolbutton-color));

background-color: var(--utrecht-mapcontrolbutton-disabled-background-color);
border-color: var(--utrecht-mapcontrolbutton-disabled-border-color);
color: var(--utrecht-mapcontrolbutton-disabled-color);
Expand All @@ -40,13 +42,14 @@

.utrecht-mapcontrolbutton--focus {
@include utrecht-focus;

--utrecht-icon-color: var(--utrecht-mapcontrolbutton-focus-color, var(--utrecht-mapcontrolbutton-color));
}

// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-mapcontrolbutton:focus:not(:disabled):not([aria-disabled="true"]):not(.utrecht-mapcontrolbutton--disabled) {
@extend .utrecht-mapcontrolbutton--focus;
@extend .utrecht-mapcontrolbutton--focus-visible;
Expand All @@ -55,7 +58,7 @@
/* override the `:focus` selector above */
/* stylelint-disable-next-line no-descending-specificity */
.utrecht-mapcontrolbutton:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-mapcontrolbutton:focus:not(:disabled):not([aria-disabled="true"]):not(.utrecht-mapcontrolbutton--disabled) {
Expand Down
4 changes: 2 additions & 2 deletions components/menulijst/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@
// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-menulijst__link:focus {
@extend .utrecht-menulijst__link--focus;
@extend .utrecht-menulijst__link--focus-visible;
}

.utrecht-menulijst__link:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-menulijst__link:focus {
Expand Down
7 changes: 4 additions & 3 deletions components/nav-top/bem.scss
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@

.utrecht-topnav__link--focus {
@include utrecht-focus;
background-color: var(--utrecht-topnav-link-focus-background-color); /*#ffd633*/

background-color: var(--utrecht-topnav-link-focus-background-color); /* #ffd633 */
color: var(--utrecht-topnav-link-focus-color, var(--utrecht-topnav-link-color));
text-decoration: var(
--utrecht-topnav-link-focus-text-decoration,
Expand All @@ -72,14 +73,14 @@
// The workaround for missing `:focus-visible` support makes the code quite complex,
// keep the ideal version around to restore it easily when browser support improves.

@if ($utrecht-focus-visible-fallback) {
@if $utrecht-focus-visible-fallback {
.utrecht-topnav__link:focus {
@extend .utrecht-topnav__link--focus;
@extend .utrecht-topnav__link--focus-visible;
}

.utrecht-topnav__link:focus:not(:focus-visible) {
@include utrecht-focus-ring-reset();
@include utrecht-focus-ring-reset;
}
} @else {
.utrecht-topnav__link:focus {
Expand Down
Loading

0 comments on commit f349a06

Please sign in to comment.