-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
232 form field component #299
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.changeset/sour-melons-fold.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
"@lux-design-system/components-react": minor | |||
"@lux-design-system/storybook": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deze regel mag weg. Storybook's versie is irrelevant
{ children, className, type, disabled, checked, ...restProps }: PropsWithChildren<LuxFormFieldLabelProps>, | ||
ref: ForwardedRef<HTMLLabelElement>, | ||
) => { | ||
const classes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit kan makkelijker in de volgende vorm:
const classNames = {
[FORM_LABEL_CLASSES.base]: true,
[FORM_LABEL_CLASSES.type]: true,
[FORM_LABEL_CLASSES.disabled]: disabled,
[FORM_LABEL_CLASSES.checked]: checked,
[className]: true,
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ik heb er nu dit van gemaakt:
const classNames = clsx(
{
[FORM_LABEL_CLASSES.base]: true,
[FORM_LABEL_CLASSES.type]: true,
[FORM_LABEL_CLASSES.disabled]: disabled,
[FORM_LABEL_CLASSES.checked]: checked,
},
className,
);
); | ||
const label = screen.getByTestId('rich-text-label'); | ||
|
||
// const label = screen.getByText((content, element) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit blokje mag weg
packages/storybook/package.json
Outdated
@@ -52,6 +52,8 @@ | |||
"@types/react-dom": "18.3.0", | |||
"@utrecht/alert-css": "1.1.0", | |||
"@utrecht/button-css": "1.2.0", | |||
"@utrecht/heading-css": "1.2.0", | |||
"@utrecht/form-label-css": "1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graag alfabetische volgorde aanhouden
|
||
# Lux Form Field Label | ||
|
||
Lux Form Field Label is gebaseerd op Utrecht Form Label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deze zin mag weg. Het is voor de gebruiker niet van belang welk component er onderwater wordt gebruikt.
Het CitationDocumentation
component is een ander geval. Daarin geven we aan dat de documentatie van Utrecht afkomt.
|
||
<Markdown>{markdown}</Markdown> | ||
|
||
## Uitbreidingen in Lux Form Field Label ten opzichte van Utrecht Form Label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Uitbreidingen in Lux Form Field Label ten opzichte van Utrecht Form Label | |
## Opmerkingen |
Zie andere comment over Utrecht componenten die onderwater worden gebruikt.
|
||
## Uitbreidingen in Lux Form Field Label ten opzichte van Utrecht Form Label | ||
|
||
- De property `type` kan de waarden `'checkbox'` of `'radio'` krijgen om specifieke stijlen toe te passen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- De property `type` kan de waarden `'checkbox'` of `'radio'` krijgen om specifieke stijlen toe te passen. | |
- De property `type` kan de waarden `checkbox` of `radio` krijgen om specifieke stijlen toe te passen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zou je deze branch kunnen rebasen op de nieuwe main
? Of er anderszijds voor zorgen dat de Heading
changes er niet meer in zitten? Die PR is zojuist gemerged.
Contents
Checklist