fix: description-list caption class #1299
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
If this closes the issue about adding a design token this PR is not yet complete. For the description-list there's a caption and a title. The caption is the optional heading above the description-list. The title is the dt which occurs for every row in the list.
According to the Figma design the title should have a different color than the detail. However neither has a color property.
This issue was about adding the color property to the title in this file https://github.com/nl-design-system/denhaag/blob/main/components/DescriptionList/src/index.scss with a reference to a new design token in this file https://github.com/nl-design-system/denhaag/blob/main/proprietary/Components/src/denhaag/description-list.tokens.json
|
@Yolijn Sorry I was confused about the naming in the ticket. I commit some new code. |
Fixed incorrect classname
Closes #1296