refactor: Icon with appearance #616
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
matijs
force-pushed
the
refactor/icon-appearance
branch
from
6056c49 to
de8073c
Compare
Replace the size prop with appearance. "size" only set size whereas "appearance" also sets a value for `--nl-icon-inset-block-start` that center aligns icons with text inline. Add dummy SVG icons, circle, square, and diamond that are "edge-to-edge" icons as well as "inset" versions that are inset by 2 in their viewBoxes. Replace all stories that used "size" with their "appearance" counterparts.
matijs
force-pushed
the
refactor/icon-appearance
branch
from
de8073c to
ee7b458
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the size prop with appearance. "size" only set size whereas "appearance" also sets a value for
--nl-icon-inset-block-startthat center aligns icons with text inline.Add dummy SVG icons, circle, square, and diamond that are "edge-to-edge" icons as well as "inset" versions that are inset by 2 in their viewBoxes.
Replace all stories that used "size" with their "appearance" counterparts.