Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: eslint configuration #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matijs
Copy link
Member

@matijs matijs commented Oct 17, 2024

  • Add eslint-plugin-react and eslint-plugin-jsx-a11y and use the recommended and jsx-runtime configurations and strict configuration on .tsx files only
  • Add @eslint/json and use the recommended configuration on .json files, treat tsconfig files as jsonc
  • Add eslint-plugin-perfectionist and autofix issues

- Add eslint-plugin-react and eslint-plugin-jsx-a11y and use the
  recommended and jsx-runtime configurations and strict configuration on
  .tsx files only
- Add @eslint/json and use the recommended configuration on .json files,
  treat tsconfig files as jsonc
@matijs matijs requested a review from Robbert October 17, 2024 18:33
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 10:44am

@@ -2,8 +2,6 @@
* @type {import('prettier').Config}
*/
export default {
printWidth: 120,
singleQuote: true,
overrides: [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zelfde hier, sorted is wat voor te zeggen, er is ook wat voor te zeggen om overrides pas na de normale settings te melden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoeft niet van mij, dan is het hek van de dam :P

Use the recommended-natural configuration and autofix issues

Make sure eslint is also run with the `--fix` option by lint-staged
@@ -2,8 +2,6 @@
* @type {import('prettier').Config}
*/
export default {
printWidth: 120,
singleQuote: true,
overrides: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoeft niet van mij, dan is het hek van de dam :P

@@ -1 +1 @@
pnpm exec lint-staged
lint-staged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waarom deze change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants