-
Notifications
You must be signed in to change notification settings - Fork 15
Add decorated Kan-on romanization #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicking, otherwise LGTM
| if (is`ๅ ฅ่ฒ ไธ็ญ`) { | ||
| if (is`ๅนซ็ต`) return 'ลซk'; | ||
| if (is`ไปฅๆฏ`) return 'แบฤซk'; | ||
| return is`่็ต ๆ ็ซ ็ต` ? 'yลซk' : 'wฤซk'; | ||
| } | ||
| if (is`ไธ็ญ`) { | ||
| return is`ๅนซ็ต` ? 'ลซng' : 'iลซng'; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (is`ๅ ฅ่ฒ ไธ็ญ`) { | |
| if (is`ๅนซ็ต`) return 'ลซk'; | |
| if (is`ไปฅๆฏ`) return 'แบฤซk'; | |
| return is`่็ต ๆ ็ซ ็ต` ? 'yลซk' : 'wฤซk'; | |
| } | |
| if (is`ไธ็ญ`) { | |
| return is`ๅนซ็ต` ? 'ลซng' : 'iลซng'; | |
| } | |
| if (is`ไธ็ญ`) { | |
| if (is`่่ฒ`) return is`ๅนซ็ต` ? 'ลซng' : 'iลซng'; | |
| if (is`ๅนซ็ต`) return 'ลซk'; | |
| if (is`ไปฅๆฏ`) return 'แบฤซk'; | |
| return is`่็ซ ็ต` ? 'yลซk' : 'wฤซk'; | |
| } |
It seems like this is the only case that there are differences between ่่ฒ and ๅ ฅ่ฒ (not including nasal โ plosive codas)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's one of a few inconsistencies in attested Kan-on that I've incorporated in here, on a somewhat arbitrary basis. I had to make a judgment call as to which ones were worth keeping. I think the rationale here was, there are a fair amount of common characters with common Kan-on that reflected these differences.
decorated_kanon.js
Outdated
| if (is`ๅๅฃ ้(่ฆ็ต ๆ ๅฝฑ็ต ๆ ไปฅๆฏ)`) return 'uรฏ'; | ||
| if (is`ๅๅฃ`) return is`ไปฅๆฏ ๆ (้็ดA้ก (ๅนซ็ต ๆ ่ฆ็ต ๆ ๅฝฑ็ต))` ? 'แบรฏ' : 'wรฏ'; | ||
| return is`ไปฅๆฏ ๆ (้็ดA้ก (ๅนซ็ต ๆ ่ฆ็ต ๆ ๅฝฑ็ต))` ? 'yรฏ' : 'รฏ'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (is`ๅๅฃ ้(่ฆ็ต ๆ ๅฝฑ็ต ๆ ไปฅๆฏ)`) return 'uรฏ'; | |
| if (is`ๅๅฃ`) return is`ไปฅๆฏ ๆ (้็ดA้ก (ๅนซ็ต ๆ ่ฆ็ต ๆ ๅฝฑ็ต))` ? 'แบรฏ' : 'wรฏ'; | |
| return is`ไปฅๆฏ ๆ (้็ดA้ก (ๅนซ็ต ๆ ่ฆ็ต ๆ ๅฝฑ็ต))` ? 'yรฏ' : 'รฏ'; | |
| if (is`ๅๅฃ ้(่ฆๅฝฑ็ต ๆ ไปฅๆฏ)`) return 'uรฏ'; | |
| if (is`ๅๅฃ`) return is`ไปฅๆฏ ๆ ้็ดA้ก ้้ณ` ? 'แบรฏ' : 'wรฏ'; | |
| return is`ไปฅๆฏ ๆ ้็ดA้ก ้้ณ` ? 'yรฏ' : 'รฏ'; |
and so on
้้ณ can actually be omitted, IIRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: ๅฝข็ด ๅข้ใปใใใตใใผใ <graphemecluster@gmail.com>
|
@syimyuzya @untunt Wanna review before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is, why this should be included in qieyun-examples? ๐ค (It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)
To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon ๐).
Not sure who you're asking ๐ but maybe it would be a good idea to formalize some "criteria for inclusion" and document them here in this repo. I just saw there were a few other obscure Middle Chinese notations here, so I figured one more would be welcome.
Thanks ๐
Fair enough. If it helps, I can make sure to handle any necessary updates to this file in the event or a Qieyun.js update. |
If that's gonna be the case, it will probably be "TUPA and reconstructions of MC or Old Mandarin only" (not even Polyhedron's romanization would make it) ๐ |
|
For my own use, I updated this code for the new version of the library, and tested in on the https://nk2028.shn.hk/tshet-uinh-autoderiver/ site. I'm not sure if there's a chance of this getting merged, but since the PR has been open this whole time, I thought, why not update the PR with the new code and see what happens ๐ Cheers! |
Hi ๐
I have a Middle Chinese notation system a little like ayaka's "็ถพ้ฆๆ่้ณ็ณป". I think it would be nice to add it to the qieyun autoderiver, if possible.