Skip to content

Conversation

@justinsilvestre
Copy link
Contributor

Hi ๐Ÿ‘‹

I have a Middle Chinese notation system a little like ayaka's "็ถพ้ฆ™ๆ€่€ƒ้Ÿณ็ณป". I think it would be nice to add it to the qieyun autoderiver, if possible.

Copy link
Member

@graphemecluster graphemecluster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking, otherwise LGTM

Comment on lines +29 to +36
if (is`ๅ…ฅ่ฒ ไธ‰็ญ‰`) {
if (is`ๅนซ็ต„`) return 'ลซk';
if (is`ไปฅๆฏ`) return 'แบฤซk';
return is`่ŽŠ็ต„ ๆˆ– ็ซ ็ต„` ? 'yลซk' : 'wฤซk';
}
if (is`ไธ‰็ญ‰`) {
return is`ๅนซ็ต„` ? 'ลซng' : 'iลซng';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is`ๅ…ฅ่ฒ ไธ‰็ญ‰`) {
if (is`ๅนซ็ต„`) return 'ลซk';
if (is`ไปฅๆฏ`) return 'แบฤซk';
return is`่ŽŠ็ต„ ๆˆ– ็ซ ็ต„` ? 'yลซk' : 'wฤซk';
}
if (is`ไธ‰็ญ‰`) {
return is`ๅนซ็ต„` ? 'ลซng' : 'iลซng';
}
if (is`ไธ‰็ญ‰`) {
if (is`่ˆ’่ฒ`) return is`ๅนซ็ต„` ? 'ลซng' : 'iลซng';
if (is`ๅนซ็ต„`) return 'ลซk';
if (is`ไปฅๆฏ`) return 'แบฤซk';
return is`่ŽŠ็ซ ็ต„` ? 'yลซk' : 'wฤซk';
}

It seems like this is the only case that there are differences between ่ˆ’่ฒ and ๅ…ฅ่ฒ (not including nasal โ†” plosive codas)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's one of a few inconsistencies in attested Kan-on that I've incorporated in here, on a somewhat arbitrary basis. I had to make a judgment call as to which ones were worth keeping. I think the rationale here was, there are a fair amount of common characters with common Kan-on that reflected these differences.

Comment on lines 87 to 89
if (is`ๅˆๅฃ ้ž(่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„ ๆˆ– ไปฅๆฏ)`) return 'uรฏ';
if (is`ๅˆๅฃ`) return is`ไปฅๆฏ ๆˆ– (้‡็ดA้กž (ๅนซ็ต„ ๆˆ– ่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„))` ? 'แบรฏ' : 'wรฏ';
return is`ไปฅๆฏ ๆˆ– (้‡็ดA้กž (ๅนซ็ต„ ๆˆ– ่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„))` ? 'yรฏ' : 'รฏ';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is`ๅˆๅฃ ้ž(่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„ ๆˆ– ไปฅๆฏ)`) return 'uรฏ';
if (is`ๅˆๅฃ`) return is`ไปฅๆฏ ๆˆ– (้‡็ดA้กž (ๅนซ็ต„ ๆˆ– ่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„))` ? 'แบรฏ' : 'wรฏ';
return is`ไปฅๆฏ ๆˆ– (้‡็ดA้กž (ๅนซ็ต„ ๆˆ– ่ฆ‹็ต„ ๆˆ– ๅฝฑ็ต„))` ? 'yรฏ' : 'รฏ';
if (is`ๅˆๅฃ ้ž(่ฆ‹ๅฝฑ็ต„ ๆˆ– ไปฅๆฏ)`) return 'uรฏ';
if (is`ๅˆๅฃ`) return is`ไปฅๆฏ ๆˆ– ้‡็ดA้กž ้ˆ้Ÿณ` ? 'แบรฏ' : 'wรฏ';
return is`ไปฅๆฏ ๆˆ– ้‡็ดA้กž ้ˆ้Ÿณ` ? 'yรฏ' : 'รฏ';

and so on
้ˆ้Ÿณ can actually be omitted, IIRC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justinsilvestre and others added 3 commits February 29, 2024 14:25
Co-authored-by: ๅฝข็ด ๅข้›†ใƒปใใ‚‰ใตใƒใƒผใ‚€ <graphemecluster@gmail.com>
@graphemecluster
Copy link
Member

@syimyuzya @untunt Wanna review before merging?

@ayaka14732 ayaka14732 requested review from syimyuzya and removed request for ayaka14732 March 8, 2024 13:13
Copy link
Member

@syimyuzya syimyuzya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is, why this should be included in qieyun-examples? ๐Ÿค” (It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)

To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon ๐Ÿ™ˆ).

@justinsilvestre
Copy link
Contributor Author

justinsilvestre commented Mar 9, 2024

The question is, why this should be included in qieyun-examples?

Not sure who you're asking ๐Ÿ˜… but maybe it would be a good idea to formalize some "criteria for inclusion" and document them here in this repo. I just saw there were a few other obscure Middle Chinese notations here, so I figured one more would be welcome.

(It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)

Thanks ๐Ÿ˜Š

To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon ๐Ÿ™ˆ).

Fair enough. If it helps, I can make sure to handle any necessary updates to this file in the event or a Qieyun.js update.

@syimyuzya
Copy link
Member

maybe it would be a good idea to formalize some "criteria for inclusion" and document them

If that's gonna be the case, it will probably be "TUPA and reconstructions of MC or Old Mandarin only" (not even Polyhedron's romanization would make it) ๐Ÿ˜‚

@justinsilvestre
Copy link
Contributor Author

For my own use, I updated this code for the new version of the library, and tested in on the https://nk2028.shn.hk/tshet-uinh-autoderiver/ site.

I'm not sure if there's a chance of this getting merged, but since the PR has been open this whole time, I thought, why not update the PR with the new code and see what happens ๐Ÿ˜› Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants