add -no-undefined for compilation on Windows #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you think you could test this pull request before the next release ? |
|
Build with the new
Hopefully it is now working for you on Windows... |
|
plenty of warning: "DLL_EXPORT" redefined because you wrongly defines DLL_EXPORT in twolame.h, cf #85 |
|
Should I revert this change until there is a better fix for Windows then?
|
|
no, there is something else to do. -no-undefined is necessary for Windows. I will create another pull request, so that you can see what is needed, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this flags as no side effect on linux as anyway all the symbols should be defined