Better fix for not allowed bitrate #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failed due to the lack of NEWS file - I am working on fixing that bug now... |
njh
added a commit
that referenced
this pull request
Nov 28, 2017
Verifying that the fix in #77 was successful
|
Added test for this fix in d218b20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new PR includes the old fix for not allowed bitrate (which caused a crash when encoding mpeg2 content) and better protection for max bitrate value in vbr encodings. This used to pass before only because
twolame_get_bitrate_indexreturned zero, which is wrong result but allowed the check to pass.