-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory Listing Payload #30
Comments
I have not actually used it for getting a directory listing, but I can't see why it would look like that. |
I suspect the binary stuff is additional headers interspersed between payloads, so caused by the bug in issue #26. |
Yes, I agree with you @colinl - it looks just like additional headers. I am going to simplify the code and test but then should probably do some testing with hardware before making another release. |
Which code in particular do you think can be simplified? |
This strips out any characters in the range 0x00 - 0x1F: Line 45 in 0e9a1ac
I am going to change it to just remove a trailing NULL. |
Ah right, I am with you now. I think you are correct, the fix for #26 should stop the headers from being there at that point in the code. Which is what I already said a few days ago, I am getting old. |
…30) standard.js: No control characters in regular expressions
The current directory listing code has an example owserver response payload of:
I have never seen anything like this in a real-world situation. And from reading the protocol documentation - I can't se how it is a valid response.
@colinl have you ever seen anything like this in the
payload
field?If not, I think I will remove the code and tests that handle this.
I have a feeling that it was due to a bug elsewhere in the code.
The text was updated successfully, but these errors were encountered: