Feat: 新增专辑封面图 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
终于看到你的回复了，那我们格式都统一为 |
|
可以的 |
|
好的，我来处理一下 |
Nayacco
reviewed
Aug 27, 2022
index.js
Outdated
| @@ -12,7 +12,7 @@ glob("./audio/**/*.{mp3,wav,flac}", {}, function (er, files) { | |||
| name: arr[3].replace(/\.(mp3|flac|wav)$/g, ''), | |||
| artist: "专辑-"+arr[2], | |||
| url: 'https://cdn.jsdelivr.net/gh/nj-lizhi/song@master' + item.slice(1), | |||
| cover: 'https://cdn.jsdelivr.net/gh/nj-lizhi/song@master/audio/cover.png', | |||
| cover: 'https://cdn.jsdelivr.net/gh/nj-lizhi/song@master/audio/' + arr[2] + 'cover.jpg', | |||
There was a problem hiding this comment.
哈喽，我发现有些图片是jpg，有些是png，可否统一一下？不然这个地方不能统一替换成 cover.jpg
另外 audio/list.js 需要重新生成，不然 cover.jpg 不能被 web 页面获取到
There was a problem hiding this comment.
@GoldSubmarine 再麻烦 review 一下呢？
封面格式统一成 .png 尺寸 500 x 500 px
There was a problem hiding this comment.
audio/list.js 好像没有重新生成诶，你需要在本地执行一下 node index.js
There was a problem hiding this comment.
OK，我在云端 run 了，重新生成了 list.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, 感谢博主分享，这次我的贡献主要是专辑【封面】
在对应专辑目录下，新增
cover.jpg封面图+ xxx/cover.jpg@GoldSubmarine @Killy412 大家帮忙看一下哈
https://github.com/nj-lizhi/song/pull/2/files