Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling with Python 3.8 (at least on macOS) #57

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

jandamm
Copy link
Contributor

@jandamm jandamm commented Jul 29, 2020

As stated here, starting from Python 3.8 python3-config has to be called with --embed in order to link to python itself.
To be backwards compatible it should always be tried with --embed and when it fails retrying without.
This is the logic implemented.

Closes #56

As stated
[here](https://docs.python.org/3/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build),
starting from Python 3.8 `python3-config` has to be called with
`--embed` in order to link to python itself.
To be backwards compatible it should always be tried with `--embed` and
when it fails retrying without.
This is the logic implemented.
@nixprime nixprime merged commit 4a60bbf into nixprime:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile on OSX with Python 3.8.3
2 participants