Correct append of -std to CXX flags #46
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach, in the presence of existing CXX flags, resulted in a broken CMAKE_CXX_FLAGS value with a `;` in the middle. The canonical way of adding a compile option is to use the cmake function `add_compile_options`, which is available from 2.8.12 onwards. If you need something compatible with cmake 2.8.11 and prior, you can use `add_definitions(-std=c++0x)` instead.
mqudsi
added a commit
to mqudsi/nvim-config
that referenced
this pull request
May 15, 2018
mqudsi
added a commit
to mqudsi/nvim-config
that referenced
this pull request
Aug 12, 2018
CtrlP is no longer maintained [0] [1] [2] and was already broken. It has a few critical faults by design that we do not have with our custom provider. Namely: * It is strictly depth-first search, * It does not have a means of automatically excluding build artifact directories, * The two combined mean that if it encounters a build directory with a zillion files, it takes FOREVER to find the match we were looking for (which is obviously not in the build directory), * It builds the file list only once, so it cannot match files that were created during the same session, 0: nixprime/cpsm#46 1: nixprime/cpsm#47 2: nixprime/cpsm#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach, in the presence of existing CXX flags, resulted
in a broken CMAKE_CXX_FLAGS value with a
;in the middle. Thecanonical way of adding a compile option is to use the cmake function
add_compile_options, which is available from 2.8.12 onwards.If you need something compatible with cmake 2.8.11 and prior, you can
use
add_definitions(-std=c++0x)instead.