Implementing mutexes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Promising, but I am hitting a couple apparent deadlocks for some reason. None of the wrapped calls should be blocking afaik... |
Turns out getcwd() itself calls stat(), which creates a nested mutex and deadlocks. Momentarily unlocking before performing getcwd() is perfectly safe as it doesn't use our preallocated buffers.
Member
Author
|
almost there, now i'm getting a deadlock at |
Thesola10
force-pushed
the
test_sema
branch
5 times, most recently
from
597dfd0 to
8d84fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will likely fix #3 I hope.