Skip to content

Implement Debug trait for PollFd (Fixes #885) #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

kccqzy
Copy link
Contributor

@kccqzy kccqzy commented Apr 20, 2018

This is useful when using printf-style debugging to observe the variables and
of the program.

This is discussed in issue #885.

@asomers
Copy link
Member

asomers commented Apr 20, 2018

How about a test? And can you put "Fixes #885" in the commit message as well as the PR description?

@kccqzy
Copy link
Contributor Author

kccqzy commented Apr 20, 2018

Good idea. I will do both.

This is useful when using printf-style debugging to observe the variables of
the program.

Also includes a test.

Fixes nix-rust#885.
@kccqzy kccqzy force-pushed the debug-trait-for-pollfd branch from 1796172 to 5e2b582 Compare April 20, 2018 02:38
@kccqzy kccqzy changed the title Implement Debug trait for PollFd Implement Debug trait for PollFd (#885) Apr 20, 2018
@kccqzy kccqzy changed the title Implement Debug trait for PollFd (#885) Implement Debug trait for PollFd (Fixes #885) Apr 20, 2018
@asomers
Copy link
Member

asomers commented Apr 20, 2018

bors r+

bors bot added a commit that referenced this pull request Apr 20, 2018
887: Implement Debug trait for PollFd (Fixes #885) r=asomers a=kccqzy

This is useful when using printf-style debugging to observe the variables and
of the program.

This is discussed in issue #885.

Co-authored-by: Zhouyu Qian <qzy@qzy.io>
@bors
Copy link
Contributor

bors bot commented Apr 20, 2018

@bors bors bot merged commit 5e2b582 into nix-rust:master Apr 20, 2018
@kccqzy kccqzy deleted the debug-trait-for-pollfd branch April 20, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants