Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support features across more platforms #739

Merged
merged 4 commits into from
Aug 22, 2017
Merged

Support features across more platforms #739

merged 4 commits into from
Aug 22, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Aug 17, 2017 •
edited
Loading

  • Exposes utsname on all platforms
  • Expose signalfd on Android

Closes #607.

@asomers
Copy link
Member

asomers commented Aug 17, 2017

sendfile has a different signature on FreeBSD than on Linux, so the build is failing.

@Susurrus
Copy link
Contributor Author

@asomers Yep, I should've labeled this as WIP as I just wanted to run these through CI to see where things would break. I'll reduce this PR to things that require almost no changes and then file issues for the rest so we can track them. This should end up being a rather small PR at the end of it.

@Susurrus Susurrus changed the title Support features across more platforms WIP: Support features across more platforms Aug 17, 2017
@Susurrus Susurrus mentioned this pull request Aug 17, 2017
Closed
@Susurrus Susurrus changed the title WIP: Support features across more platforms Support features across more platforms Aug 18, 2017
@Susurrus
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 21, 2017
@bors
Merge #739
b76cbee 
739: Support features across more platforms r=Susurrus

 * Exposes `utsname` on all platforms
 * Expose `signalfd` on Android

Closes #607.
@bors
Copy link
Contributor

bors bot commented Aug 22, 2017

Build succeeded

@bors bors bot merged commit c787799 into nix-rust:master Aug 22, 2017
@Susurrus Susurrus mentioned this pull request Aug 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Susurrus @asomers