Improve AIO API #506
Merged
Improve AIO API #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent immutable buffers from being used with aio_read or lio_listio with LIO_READ. AioCb.from_slice no longer needs to be unsafe.
If an AioCb has any in-kernel state, AioCb.drop will print a warning and wait for it to complete.
|
Some of these changes were requested by @posborne . Perhaps he could review it? |
|
r? @posborne |
|
@asomers Changes look good. Can you look at addressing the OSX failure reported by CI? |
Also, fix style bug in AIO tests
Closed
|
Given that there are no more OSX failures in the CI anymore, we should merge it. Since @posborne looked at the source, he should do it :) |
|
@homu r+ |
|
📌 Commit e29c0ef has been approved by |
homu
added a commit
that referenced
this pull request
Feb 27, 2017
Improve AIO API - Turn most `aio_*` functions into `AioCb` methods - Add runtime checks to `AioCb` methods - Implement `Drop` for `AioCb`
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aio_*functions intoAioCbmethodsAioCbmethodsDropforAioCb