Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MIPS targets #301

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Add support for MIPS targets #301

merged 1 commit into from
Mar 11, 2016

Conversation

gabrielesvelto
Copy link
Contributor

Closes #300

@gabrielesvelto
Copy link
Contributor Author

I've slightly reorganized the code dealing with CPU sets so that ARM and MIPS have a CPU_SETSIZE limited to 32 only under Android (i.e. when using bionic) but use the full Linux CPU_SETSIZE otherwise. To work correctly this also needs a fix to the libc crate which I've pushed here: rust-lang/libc#217

@posborne
Copy link
Member

posborne commented Mar 7, 2016

Awesome, MIPS/MIPSEL are targets that will be tested (at least for compilation) when #297 (or whatever follows and integrates with travis) lands.

I'll hold off on approving until the changes in libc are published. If we can get the CI changes in places and merged in soonish @humu can check that everything works.

@gabrielesvelto
Copy link
Contributor Author

The change to libc has landed and it's available in version 0.2.8 of the crate: rust-lang/libc@2278a54

@gabrielesvelto
Copy link
Contributor Author

The dependency in libc has landed, is there anything else needed before this can be merged?

@kamalmarhubi
Copy link
Member

@homu r+

@posborne I figure we can fix any issues that come up in CI when we turn it on.

@homu
Copy link
Contributor

homu commented Mar 11, 2016

📌 Commit 86b3cfa has been approved by kamalmarhubi

@homu
Copy link
Contributor

homu commented Mar 11, 2016

⌛ Testing commit 86b3cfa with merge d53950a...

homu added a commit that referenced this pull request Mar 11, 2016
@homu
Copy link
Contributor

homu commented Mar 11, 2016

☀️ Test successful - status

@homu homu merged commit 86b3cfa into nix-rust:master Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants