Reexport crate::poll_timeout::PollTimeoutTryFromError; #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, werid Thanks! |
SteveLauC
approved these changes
Feb 11, 2025
SteveLauC
reviewed
Feb 11, 2025
src/sys/epoll.rs
Outdated
| @@ -1,5 +1,6 @@ | |||
| use crate::errno::Errno; | |||
| pub use crate::poll_timeout::PollTimeout as EpollTimeout; | |||
| pub use crate::poll_timeout::PollTimeoutTryFromError; | |||
There was a problem hiding this comment.
Suggested change
| pub use crate::poll_timeout::PollTimeoutTryFromError; | |
| pub use crate::poll_timeout::PollTimeoutTryFromError as EpollTimeoutTryFromError; |
There was a problem hiding this comment.
I could, but I think this would lead in even more confusion. Consider this page: https://docs.rs/nix/latest/nix/sys/epoll/struct.EpollTimeout.html
It mentions EpollTimeout 3 times, it mentions the original name (PollTimeout) 68 times.
There was a problem hiding this comment.
(did it anyway, it's not that important)
There was a problem hiding this comment.
It mentions EpollTimeout 3 times, it mentions the original name (PollTimeout) 68 times.
Didn't expect that 🤦♂️, hope cargo doc will respect alias one day...
|
Mind doing it to Line 5 in 003bfe4 pub use crate::poll_timeout::PollTimeoutTryFromError; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
impl TryFrom<i16> for PollTimeoutuses a custom error (PollTimeoutTryFromError), but the error type is not public so handling this error is not really possible. All this PR does is making the type public.Normally something complains when you try to use private type in a public interface, not sure why is it not happening here.
Checklist:
CONTRIBUTING.md