Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make test_parsing_kernel_version() private #2501

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Sep 14, 2024

What does this PR do

The test function test_parsing_kernel_version() is public, which is unnecessary since it is under attribute #[test]. Also, it causes the CI failure in PR #2500:

error: missing documentation for a function
   --> src/features.rs:95:5
    |
95  |     pub fn test_parsing_kernel_version() {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:121:12
    |
121 |     #[deny(missing_docs)]
    |            ^^^^^^^^^^^^

error: could not compile `nix` (lib test) due to 1 previous error

so let's make it private.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC added this pull request to the merge queue Sep 14, 2024
Merged via the queue into nix-rust:master with commit 6cfbf2d Sep 14, 2024
38 checks passed
@SteveLauC SteveLauC deleted the refactor/clippy branch September 14, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants