-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcntl: adding macOs F_RDADVISE flag #2480
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Add socket option `IPV6_PKTINFO` for BSDs/Linux/Android, also `IPV6_RECVPKTINFO` for DragonFlyBSD | ||
Add socket option `IPV6_PKTINFO` for BSDs/Linux/Android, also `IPV6_RECVPKTINFO` for DragonFlyBSD |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add fcntl constant `F_RDADVISE` for Apple target |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -797,6 +797,9 @@ pub enum FcntlArg<'a> { | |
/// Return the full path without firmlinks of the fd. | ||
#[cfg(apple_targets)] | ||
F_GETPATH_NOFIRMLINK(&'a mut PathBuf), | ||
/// Issue an advisory read async with no copy to user | ||
#[cfg(apple_targets)] | ||
F_RDADVISE(libc::radvisory), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw this was changed in the "testing" commit, the previous API is indeed a bit unclear:
I am actually thinking about this: F_RDADVISE {
offset: off_t,
count: c_int,
} So semantically, the API will be more clear and users won't need to bother with the libc raw structure. The drawback is, we need to copy these 2 numbers, considering they are simply numbers, IMHO, it is fine to copy them. Your thoughts? 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was being consistent with flags passing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Get it, makes sense to me then:) |
||
// TODO: Rest of flags | ||
} | ||
|
||
|
@@ -905,6 +908,10 @@ pub fn fcntl<Fd: std::os::fd::AsFd>(fd: Fd, arg: FcntlArg) -> Result<c_int> { | |
*path = PathBuf::from(OsString::from(optr.to_str().unwrap())); | ||
return Ok(ok_res) | ||
}, | ||
#[cfg(apple_targets)] | ||
F_RDADVISE(rad) => { | ||
libc::fcntl(fd, libc::F_RDADVISE, &rad) | ||
} | ||
} | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was accidentally modified, please revert it.