-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epoll timeout #2202
Merged
SteveLauC
merged 1 commit into
nix-rust:master
from
JonathanWoollett-Light:epoll-timeout
Nov 25, 2023
Merged
Epoll timeout #2202
SteveLauC
merged 1 commit into
nix-rust:master
from
JonathanWoollett-Light:epoll-timeout
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked on #1876 |
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
November 23, 2023 01:14
84260f1
to
64e3af6
Compare
Can you please rebase to resolve the conflict? |
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
November 23, 2023 18:23
64e3af6
to
0253dfa
Compare
Rebased. |
asomers
requested changes
Nov 23, 2023
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
4 times, most recently
from
November 24, 2023 15:15
b79c2b8
to
3df6d9d
Compare
asomers
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you please add a CHANGELOG?
JonathanWoollett-Light
force-pushed
the
epoll-timeout
branch
from
November 24, 2023 18:28
3df6d9d
to
edb4cf4
Compare
Added. |
asomers
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Makes the
PollTimeout
from #1876 generic so it can be used byEpoll
.Checklist:
CONTRIBUTING.md