Skip to content

Add support for LoongArch #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 11, 2023
Merged

Add support for LoongArch #2045

merged 1 commit into from Aug 11, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented May 29, 2023

This PR adds basic support for LoongArch and does not include CI for now.

@heiher
Copy link
Contributor Author

heiher commented Jun 5, 2023

r? @asomers

@heiher
Copy link
Contributor Author

heiher commented Jul 29, 2023

@asomers Friendly ping.

@heiher
Copy link
Contributor Author

heiher commented Aug 7, 2023

Hello, @asomers Could you review this PR please? Thanks.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with loongarch is that it's just a vanity architecture. It has no reason for being except "we wanted our own architecture designed in China". And as a volunteer, I don't want to spend my precious few hours working to support somebody's vanity project. I'll go ahead and merge this because it is literally just a single line. But I won't merge more complicated loongarch support. It isn't worth my time, and it doesn't benefit other Nix users, either.

@asomers asomers added this pull request to the merge queue Aug 11, 2023
Merged via the queue into nix-rust:master with commit 981dc1c Aug 11, 2023
@heiher
Copy link
Contributor Author

heiher commented Aug 14, 2023

Hello, thank you for sharing your perspective. I understand your view on the LoongArch architecture. However, I believe that our work in the open-source community goes beyond satisfying personal vanity; it's about fostering technological diversity and innovation. LoongArch, as a new architecture, might present new opportunities and challenges for the computing landscape in China.

While you hold a different opinion, I think it's important for us as volunteers to maintain an open-minded approach, respecting various technological explorations, and striving to contribute to the community. If you find the complexity of supporting LoongArch to be overwhelming, I understand your reluctance to invest extensive time. Nevertheless, I hope you can consider that such work might have positive impacts on certain individuals. In open-source projects, our efforts often benefit a broader user base, even if it's not immediately evident.

Ultimately, the decision rests with you, but I encourage us to collectively work towards the betterment of the community, contributing to the advancement and innovation of technology. Thank you for your time and understanding. ❤️

donmor added a commit to donmor/nix that referenced this pull request Jul 21, 2024
KexyBiscuit added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jul 21, 2024
FIXME: Too many dependencies on old versions of nix, which has no LoongArch support until 0.27.0
nix-rust/nix#2045
HmnSn added a commit to HmnSn/bmart that referenced this pull request May 22, 2025
bump nix version to fix building on loongarch64 
Link: nix-rust/nix#2045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants