Added getters for the MqAttr struct #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtzoeller
requested changes
Dec 26, 2021
src/mqueue.rs
Outdated
Comment on lines
78
to
81
| /// The number of messages currently held in the queue | ||
| pub const fn current_msg(&self) -> mq_attr_member_t { | ||
| self.mq_attr.mq_curmsgs | ||
| } |
There was a problem hiding this comment.
I'm not sure how I feel about the naming here. cur is expanded to current, but we don't expand msg, and the underscores aren't present in the libc definitions.
For consistency with the rest of nix (example below), I'd lean towards using the same names as the underlying fields, minus the mq_ prefix. @asomers thoughts?
Lines 1270 to 1273 in a392647
There was a problem hiding this comment.
I'm good with that. Seems more consistent. I can fix it.
|
LGTM. Just squash your commits and I'll merge it. |
fpagliughi
force-pushed
the
mqattr_getters
branch
from
9b03b01
to
80f447b
Compare
rtzoeller
approved these changes
Dec 28, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the existing code, if you call
mq_getattr(), there does not appear to be a way to get any of the attributes from the returnedMqAttrstruct, other than the flags. This adds getter functions to retrieve the size parameters of the queue, and the current number of messages in the queue.