Fix unsoundness in FdSet methods #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
reviewed
Oct 19, 2021
asomers
reviewed
Oct 21, 2021
taylordotfish
force-pushed
the
fix-fdset-unsoundness
branch
from
a8c61ed
to
88671ed
Compare
|
I'm afraid you'll have to rebase to fix the test failures. |
Ensure file descriptors are nonnegative and less than `FD_SETSIZE`. (Fixes nix-rust#1572.)
taylordotfish
force-pushed
the
fix-fdset-unsoundness
branch
from
88671ed
to
dc80b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure file descriptors are nonnegative and less than
FD_SETSIZE. (Fixes #1572.)