expose process_vm_readv, process_vm_writev for android #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could you please add a CHANGELOG entry and squash your commits? |
rupansh
force-pushed
the
master
branch
2 times, most recently
from
0aa9923
to
32b125f
Compare
|
done @asomers |
asomers
approved these changes
Oct 18, 2021
|
@rupansh can you rebase this? Thanks! |
rupansh
force-pushed
the
master
branch
2 times, most recently
from
e368882
to
1c66fd8
Compare
|
done @rtzoeller |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2022
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh see rust-lang/libc#1878 Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2022
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh see rust-lang/libc#1878 Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
|
Timed out. |
|
@rupansh you probably need to rebase to satisfy bors. |
|
@rupansh apologies for the confusion and back and forth. There was an issue with our CI provider which is now resolved, but unfortunately in validating the fix a PR was submitted which made your PR conflict (I had originally planned to submit them in the opposite order). Can you rebase again, hopefully for the final time? 😅 |
CHANGELOG: add process_vm_* entry process_vm_*: fix documentation for android expose process_vm_readv, process_vm_writev for android Signed-off-by: rupansh-arch <rupanshsekar@hotmail.com>
|
done @rtzoeller |
|
bors r+ |
rtzoeller
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rust-lang/libc#1878