Implement AsRawFd for PollFd #1516
Conversation
Implement the trait on PollFd, providing an `as_raw_fd()` accessor to get the RawFd associated with the PollFd. Subsumes nix-rust#1147, nix-rust#1286. Closes nix-rust#1146. Test: `cargo test --test test test_pollfd_fd`
|
Will have a CHANGELOG.md conflict with #1515, which is one of the annoying aspects of maintaining a Changelog file in-repo. |
There was a problem hiding this comment.
Yes, CHANGELOG conflicts are common and annoying. The saltstack project does something cool, which is to create a separate file for the changelog entry of every PR. Then when they make a release they run a script to merge those changelog entries into the main CHANGELOG. I think something like that would work well for Nix.
bors r+
|
Another changelog idea I've seen is formatting commits such that a tool can construct the document from them. E.g., https://www.conventionalcommits.org/en/v1.0.0/ . |
|
I've seen that one. But I don't think it would work. Enforcing consistent commit message is harder than enforcing consistent changelog entries, especially on a project with so many different contributors. |
|
I think it should be enforceable via bors / pre-commit CI check, but I haven't investigated very hard. |
Implement the trait on PollFd, providing an
as_raw_fd()accessor toget the RawFd associated with the PollFd.
Subsumes #1147, #1286. Closes #1146.
Test:
cargo test --test test test_pollfd_fd