Add a wrapper around if_nameindex#1445
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Jun 6, 2021
Merged
Conversation
coolreader18
force-pushed
the
if_nameindex
branch
from
7094a2d to
cb5290f
Compare
asomers
requested changes
Jun 6, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks pretty good! Don't forget to add a CHANGELOG entry.
coolreader18
force-pushed
the
if_nameindex
branch
2 times, most recently
from
7f88c6c to
2a02f0b
Compare
asomers
requested changes
Jun 6, 2021
| /// for iface in &interfaces { | ||
| /// println!("Interface #{} is called {}", iface.index(), iface.name().to_string_lossy()); | ||
| /// } | ||
| /// # nix::Result::Ok(()) |
Member
There was a problem hiding this comment.
I guess this works, but it would be in keeping with the style of the other doc tests if you return () here, and do an .unwrap() above instead of ?.
Contributor
Author
There was a problem hiding this comment.
Ah, alright, hadn't noticed that pattern.
Contributor
Author
There was a problem hiding this comment.
Oh, though note that the # means that line will be hidden from the docs; readers won't see that it returns Ok(())
coolreader18
force-pushed
the
if_nameindex
branch
from
2a02f0b to
19182b9
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.