Skip to content

setresuid doesn't support no-change for any of its arguments #931 #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ritzk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setresuid doesn't support no-change for any of its arguments #931 #1305

ritzk wants to merge 1 commit into from

Conversation

@ritzk
Copy link
Contributor

@ritzk ritzk commented Oct 4, 2020 •
edited
Loading

based of #1009

asomers
asomers requested changes Oct 10, 2020
View reviewed changes
@ritzk ritzk force-pushed the setresuid branch 2 times, most recently from 9d9c9d2 to 9863ee2 Compare October 11, 2020 03:26
@ritzk ritzk requested a review from asomers October 12, 2020 01:27
asomers
asomers reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that somehow you screwed up the commit message of one of the commits. Would you mind squashing and fixing the commit message?

@ritzk
Copy link
Contributor Author

ritzk commented Oct 12, 2020

Looks good, except that somehow you screwed up the commit message of one of the commits. Would you mind squashing and fixing the commit message?

done.

asomers
asomers previously requested changes Oct 12, 2020
View reviewed changes
@ritzk ritzk requested a review from asomers October 22, 2020 16:08
@kamalmarhubi
Copy link
Member

kamalmarhubi commented Nov 11, 2020

looks like requested changes were made, so

bors r+

kamalmarhubi
kamalmarhubi approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@kamalmarhubi kamalmarhubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe bors needs and approving review?

@kamalmarhubi kamalmarhubi dismissed asomers’s stale review November 11, 2020 01:23

changes were made

bors bot added a commit that referenced this pull request Nov 11, 2020
@bors @ritzk
Merge #1305
a0a6af0 
1305:  setresuid doesn't support no-change for any of its arguments #931  r=kamalmarhubi a=ritzk

based of #1009 

- Fixes #931 ( support for -1 in argument to setresuid/setresgid)

Co-authored-by: Ritesh Khadgaray <khadgaray@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 11, 2020

Timed out.

@asomers
Copy link
Member

asomers commented Nov 15, 2020

bors retry

bors bot added a commit that referenced this pull request Nov 15, 2020
@bors @ritzk
Merge #1305
c7ff603 
1305:  setresuid doesn't support no-change for any of its arguments #931  r=kamalmarhubi a=ritzk

based of #1009 

- Fixes #931 ( support for -1 in argument to setresuid/setresgid)

Co-authored-by: Ritesh Khadgaray <khadgaray@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 15, 2020

Build failed:

@naoNao89 naoNao89 mentioned this pull request Nov 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamalmarhubi kamalmarhubi kamalmarhubi approved these changes

@asomers asomers Awaiting requested review from asomers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setresuid doesn't support no-change for any of its arguments

3 participants

@ritzk @kamalmarhubi @asomers