Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify policy on breaking changes #458

Open
chaosagent opened this issue Nov 6, 2016 · 3 comments
Open

Clarify policy on breaking changes #458

chaosagent opened this issue Nov 6, 2016 · 3 comments
Milestone

Comments

@chaosagent
Copy link
Contributor

Theres no general policy on breaking changes in CONTRIBUTING.md; I think it'd be useful to have one.

@fiveop
Copy link
Contributor

fiveop commented Nov 7, 2016

I think the current consensus is, that breaking things in order to make the code follow CONVENTIONS.md or to fix some problem (not necessarily a bug, see #445 for example) is fine. When we start to think about a 1.0 version, that will change. Feel free to write a paragraph stating that as a PR, that we can then further discus. If you don't, I might get around to it next week.

@posborne
Copy link
Member

posborne commented Nov 7, 2016

Yep, at this point we don't want to break APIs unless there is a good reason. But if there is a good reason, then I think it still makes sense to do so (and semver will change accordingly).

@kamalmarhubi
Copy link
Member

Thanks for asking about this. We should definitely figure this out.

@fiveop fiveop self-assigned this Nov 15, 2016
@Susurrus Susurrus added this to the 1.0 milestone Nov 5, 2017
@fiveop fiveop removed their assignment Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants