Skip to content

Fix flag type names to match FOO_* => FooFlags convention #317

Open
@kamalmarhubi

Description

@kamalmarhubi

The convention was added in #287, and there are a few places that need changing. I'm going through all the bitflags as part of #315, and noticing them. Here's a (partial) list:

  • poll::EventFlags => PollFlags (1)
  • sys::epoll::EpollEventKind => EpollFlags (1)
  • sys::event::EventFlag => EvFlags
  • sys::event::FilterFlag => NoteFlags
  • sys::eventfd::EventFdFlag => EFdFlags
  • sys::memfd::MemFdCreateFlag => MFdFlags
  • sys::quota::QuotaValidFlags => QIFFlags (unsure about capitalization)
  • sys::stat::{SFlag, Mode} => SFlags? (2)
  • sys::statvfs::FsFlags => use sys::mount::MsFlags? (3)
  • sys::termios::{InputFlags, OutputFlags, ControlFlags, LocalFlags} => ? (4)

(1) these might need amending the convention. The flags are named POLLIN, POLLOUT, EPOLLIN, EPOLLOUT, etc: there is no underscore

(2) these are used in different parameters; needs to looked at a bit more carefully

(3) man page for statvfs(2) says

The field f_flag is a bit mask (of mount flags, see mount(8)).

(4) These flags have no common prefix.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions